Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show all channels for updatable add-ons if a beta/dev add-on has been installed #16637

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented May 31, 2024

Link to issue number:

None

Summary of the issue:

If a beta/dev add-on has been installed, updates for that add-on are not displayed by default when going to the updatable add-ons tab.
This is because the default channel view for updatable add-ons is always "Stable".
Instead, it would be helpful to show beta/dev add-ons if these have been installed previously.

Description of user facing changes

If a beta/dev add-on has been installed, add-ons of all channels will show up by default in the updatable add-ons tab

Description of development approach

Set the filter key depending on if beta/dev add-ons have been installed

Testing strategy:

Manual testing by installing a beta add-on

Known issues with pull request:

Note: this switches the default to all if any beta/dev add-on has been installed, not necessarily the one with updates available

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner May 31, 2024 05:59
@seanbudd seanbudd requested a review from michaelDCurran May 31, 2024 05:59
@AppVeyorBot
Copy link

See test results for failed build of commit c8931fc3e8

@CyrilleB79
Copy link
Collaborator

@seanbudd, this strategy cause the following issue:

If I collaborate on an add-on, e.g. Windows Essential, I want to follow dev channel. For all my other installed add-ons (e.g. Instant Translate, Outlook Extended), I want to stick on the stable channel. When updates are available, I'd like to display dev channel for Windows Essential but only stable for Outlook Extended or Instant Translate, so that I can select all in updatable add-on tab and update.

The solution, although technically more complex, would be to have a filter displaying stable updates for stable add-ons, beta updates for beta add-ons and dev updates for dev add-ons.

@seanbudd
Copy link
Member Author

@CyrilleB79 - I see this as a separate use case outside of the scope of this PR. I think this could be implemented by creating a new channel filter key for "same channel" in the updatable tab

@seanbudd
Copy link
Member Author

See also #16636 which may cover your use case as auto-updates and update notifications will only be for the same channel in the first implementation

@seanbudd seanbudd merged commit d16801a into master Jun 3, 2024
3 checks passed
@seanbudd seanbudd deleted the showAllChannelsMore branch June 3, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants